recipes icon indicating copy to clipboard operation
recipes copied to clipboard

`jq` fails in `fastly-meta/6.4/bin/setup-fastly.sh` because of outdated fastly cli

Open m-waes opened this issue 1 year ago • 1 comments

Hi,

| jq crashes in this line:

remoteContent=$(fastly vcl snippet describe --version=active "--name=$name" --json | jq -r '.Content') because the remote content looks like this

HOME=/tmp /tmp/fastly/fastly vcl snippet describe --version=active --name=shopware_deliver --json

{
  "Content": "# Remove the exact PHP Version from the response for more security (e.g. 404 pages)\nunset resp.http.x-powered-by;\n\n# We use fastly.ff.visits_this_service to avoid running this logic on shield nodes. We only need to\n# run it on edge nodes\nif (fastly.ff.visits_this_service == 0 \u0026\u0026 resp.http.sw-invalidation-states) {\n  # invalidation headers are only for internal use\n  unset resp.http.sw-invalidation-states;\n\n  ## we don't want the client to cache\n  set resp.http.Cache-Control = \"no-cache, private\";\n}\n",
  "CreatedAt": "...",
  "DeletedAt": null,
  "Dynamic": 0,
  "ID": "...",
  "Name": "shopware_deliver",
  "Priority": 100,
  "ServiceID": "...",
  "ServiceVersion": 4,
  "Type": "deliver",
  "UpdatedAt": "..."
}

A new version of the Fastly CLI is available.
Current version: 10.6.4
Latest version: 11.2.0
Run `fastly update` to get the latest version.

which is invalid json, because somehow the fastly cli version warning made it into the snippet.

I'm sure I can solve this by updating the cli or manually uploading the correct snippets, but I just wanted to report the behavior.

For context:

composer show shopware/fastly-meta | grep versions
versions : * 6.4.15.0
composer show shopware/core | grep versions
versions : * v6.5.8.7

m-waes avatar Apr 16 '25 09:04 m-waes

The default recipe does not use that anymore since 6.5. The new way is through deployment helper where this is implemented in PHP. https://github.com/shopware/recipes/blob/main/shopware/paas-meta/6.5/.platform/applications.yaml#L89

shyim avatar Apr 16 '25 11:04 shyim

closed due inactivity

shyim avatar May 05 '25 05:05 shyim