production icon indicating copy to clipboard operation
production copied to clipboard

Decouple the application from the global state

Open jkrzefski opened this issue 3 years ago • 5 comments

This will decouple the application from the global state of its surrounding infrastructure using the Symfony Runtime Component. In his talk at Symfony World 2021 Tobias Nyholm made some compelling arguments for this change.

jkrzefski avatar Jun 19 '21 23:06 jkrzefski

I don't see any benefit here when the actual application does not run on the other runtimes.

shyim avatar Jun 20 '21 09:06 shyim

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-16816

Please use this issue to track the state of your pull request.

shopwareBot avatar Aug 23 '21 07:08 shopwareBot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: jkrzefski
:x: NiklasLimberg
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 06 '21 09:09 CLAassistant

Hi @jkrzefski, I rebased it and resolved the merge conflict but it seems to break the pipeline internally so this could take a while.

NiklasLimberg avatar Sep 06 '21 09:09 NiklasLimberg

Hi @jkrzefski, I rebased/merged this incorectly and it took me a few weeks to notice. I fixed it, but now it has to wait for the next release. If you want to know why ask @shyim

NiklasLimberg avatar Sep 23 '21 11:09 NiklasLimberg

Hey,

We will not merge this until 6.5 as it could be breaking. BUT! it's already merged for the new template based on Symfony Flex: https://github.com/shopware/recipes/commit/ee809d1be8639f96a4c6048ede215b7e2b993743

To set up a Project using Flex use composer create-project shopware/production:dev-flex <project-name>

Thanks!

shyim avatar Sep 26 '22 07:09 shyim