shopware
feat: added Pagination for Wishlist
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| shopware-frontends-docs | ✅ Ready (Inspect) | Visit Preview | Jul 14, 2024 6:38pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
CodSpeed Performance Report
Merging #893 will not alter performance
Comparing khanSoliheen:paginationForWishlistOrderHistoryPage (0c683e7) with main (fd3c3a8)
Summary
✅ 9 untouched benchmarks
![codspeed-hq[bot] avatar](https://avatars.githubusercontent.com/in/257293?v=4 "Published by a pub.dev verified publisher"){kind=small}
hey, looks really good 🙌🏼
👉🏼 Could you please adjust the tests because they are failing
@kstala maybe you can help here? Would be nice to get this merged.
@mkucmus, @kstala, and @khanSoliheen, I fixed the Test for the useWishlist composable.
Now, we have 100% coverage for the useWishlist composable. :tada:
Can be tested here: https://frontends-demo-h3h90r2m2-shopware-frontends.vercel.app/
@mkucmus and @patzick fixed the ts errors, updated tests, tested orders pagination, and fixed it.
You can review it again. I added @kstala for testing, also.
@BrocksiNet can you take a look at this, I have 2 problems (both cases involve guest user)
-
as a guest user, adding a product to the wishlist doesn't update the number on the heart wishlist icon https://github.com/shopware/frontends/assets/30267600/0548bf58-c9ff-4530-a59b-5bb52a191a9e
-
pagination for wishlist doesn't work for guest users https://github.com/shopware/frontends/assets/30267600/aa48c1d9-bf11-475f-b576-d05393a269df
FYI: I removed the wishlist call from onMounted because it is not needed information for SSR. I now make sure that the wishlist call is only executed once per page (on the client side), not twice on the wishlist page (like it was before). So overall, this will improve the SSR times a bit.