frontends icon indicating copy to clipboard operation
frontends copied to clipboard

feat: simplify generated open api structure and manual overrides

Open patzick opened this issue 1 year ago • 2 comments

Description

Draft of incoming generator changes. More detailed description will show up here soon.

Type of change

For canary - breaking but simplifying, migration path will be provided. For stable - breaking but more simple than current stable->canary transition.

ToDo's

  • [x] test and generate query params
  • [x] test and generate path params
  • [x] test and generate headers
  • [ ] (optional) override only part of schema/operation
  • [x] rewrite RequestParameters and RequestReturnType
  • [ ] migrate creating admin client
  • [ ] ...

patzick avatar Apr 15 '24 07:04 patzick

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ❌ Failed (Inspect) Jun 5, 2024 9:04am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jun 5, 2024 9:04am

vercel[bot] avatar Apr 15 '24 07:04 vercel[bot]

CodSpeed Performance Report

Merging #871 will degrade performances by 90.97%

Comparing feat/api-client-new-structure (70af765) with main (9ce8d65)

Summary

❌ 4 (👁 4) regressions ✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/api-client-new-structure Change
👁 [api-client][transformPathToQuery] - transform with header params 61.7 µs 77.9 µs -20.7%
👁 [api-client][transformPathToQuery] - transform with path,query,body,header params 84.6 µs 280.2 µs -69.81%
👁 [api-client][transformPathToQuery] - transform with query params 62.3 µs 69.8 µs -10.63%
👁 [api-gen][generate] - generate schema command 412.3 ms 4,566.7 ms -90.97%

codspeed-hq[bot] avatar Apr 15 '24 08:04 codspeed-hq[bot]