frontends icon indicating copy to clipboard operation
frontends copied to clipboard

feat(vue-demo): broadcasting

Open mdanilowicz opened this issue 1 year ago • 5 comments

Description

closes #788

Type of change

ToDo's

Screenshots (if applicable)

Additional context

mdanilowicz avatar Apr 11 '24 18:04 mdanilowicz

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Jun 25, 2024 0:08am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jun 25, 2024 0:08am

vercel[bot] avatar Apr 11 '24 18:04 vercel[bot]

CodSpeed Performance Report

Merging #866 will not alter performance

Comparing feat/GH-788 (084b895) with main (c729e70)

Summary

✅ 9 untouched benchmarks

codspeed-hq[bot] avatar Apr 11 '24 18:04 codspeed-hq[bot]

After logging out, the mini-cart is not updated. :thinking:

Also, I am asking myself if this will make that issue https://github.com/shopware/frontends/issues/767 even worse, so we break the bfcache with that new BroadCastingChannel "again".

BrocksiNet avatar Apr 15 '24 14:04 BrocksiNet

After logging out, the mini-cart is not updated. 🤔

Same behaviour we have on the main. It looks like a bug. I created a new task for that

Also, I am asking myself if this will make that issue #767 even worse, so we break the bfcache with that new BroadCastingChannel "again".

Why? It is not related to the navigation

mdanilowicz avatar Apr 15 '24 14:04 mdanilowicz

What about not refreshing the session context in every tab but passing in the current context instead? This way, every tab shares the same context and no need to invoke refresh X times.

Done

mdanilowicz avatar Apr 22 '24 11:04 mdanilowicz