frontends icon indicating copy to clipboard operation
frontends copied to clipboard

feat(vue-demo-store): disable isr for catch all route

Open mkucmus opened this issue 10 months ago • 3 comments

Description

due to issue #1652 we have to disable the isr for default vercel rendering mode.

filtering in SSR works as expected: https://frontends-demo-git-feat-disable-isr-f-7f52d6-shopware-frontends.vercel.app/Products/?manufacturer=cd26289d022045aa81cbe6be0d312bfd&order=name-asc

Type of change

ToDo's

Screenshots (if applicable)

Additional context

mkucmus avatar Feb 06 '25 14:02 mkucmus

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Feb 17, 2025 8:21am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Feb 17, 2025 8:21am

vercel[bot] avatar Feb 06 '25 14:02 vercel[bot]

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1674
@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1674
@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1674
@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1674
@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1674
@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1674

commit: e57cfed

pkg-pr-new[bot] avatar Feb 06 '25 14:02 pkg-pr-new[bot]

It's fixing only listing pages with filtering, but removes a very good caching option overall

what about reloading it on CSR when query params are present?

for comparision:

  • https://frontends-demo-git-feat-disable-isr-f-7f52d6-shopware-frontends.vercel.app/Specials-Sale/
  • https://frontends-demo.vercel.app/Specials-Sale/

page is loading over 10x slower without ISR

patzick avatar Feb 11 '25 09:02 patzick

closing for now, we need another solution

patzick avatar May 05 '25 07:05 patzick