docker icon indicating copy to clipboard operation
docker copied to clipboard

How can one access the docker base image in a github release manner?

Open JoshuaBehrens opened this issue 8 months ago • 9 comments

In the README one can see this line

FROM ghcr.io/shopware/docker-base:8.2-nginx as base-image

This image seems to have been changed by removing /usr/local/shopware/setup_6.6.x This should not be an issue as this change has been released in 0.3.0 but there seems no obvious way to downgrade to 0.2.0 build.

How can I ensure that, so I do not have to pin the image to an unreadable hash?

JoshuaBehrens avatar Mar 15 '25 14:03 JoshuaBehrens

The tags are only there for composer recipes. They don't do anything. You should use the hash

shyim avatar Mar 16 '25 08:03 shyim

When you use the hash, you should set for your own an https://github.com/aquasecurity/trivy scan, so you know when to update the sha because of security updates

shyim avatar Mar 17 '25 07:03 shyim

Can this be closed then 🤔

shyim avatar Mar 19 '25 12:03 shyim

@shyim it is a solution but I am not happy about it as some base-image upgrades were breaking already. Even when trivy finds an update it will contain more than just a bugfix but also breaking changes. So not easy to upgrade easily.

JoshuaBehrens avatar Mar 21 '25 12:03 JoshuaBehrens

I don't know, to be honest, if you want to do proper image tagging by caddy/nginx + PHP version + break tagging. I also don't think that we gonna change anything here anymore, this change with the setup script was deprecated for several months we even added a ugly sleep so people should notice it

shyim avatar Mar 21 '25 12:03 shyim

Wait. This is now deprecated to use? This could've been better than an ugly sleep. Some just accept slow CI/CD as long as it works

JoshuaBehrens avatar Mar 22 '25 22:03 JoshuaBehrens

We initially had this setup script, which did some bash wufuu to install or update Shopware. As we are aiming to unify setups across setups, we created deployment helper in PHP to make this portable in any environment. Therefore we deprecated that script last year summer and removed it January. Since then, the setup script checks if the deployment helper is installed and invokes it; it throws an error install please deployment helper.

shyim avatar Mar 24 '25 07:03 shyim

Ah ok that part. Got it. I thought this docker base image was deprecated already. Got you

JoshuaBehrens avatar Mar 24 '25 09:03 JoshuaBehrens

randomly saw, https://github.com/pimcore/docker#versioning we could adopt that too..

shyim avatar Mar 24 '25 10:03 shyim