Mike Angell

Results 39 comments of Mike Angell

Rails has nice support for all of these including good i18n support. Maybe can just open these up in Shopify

I'm down for the named params, I was considering this as it is a similar approach used by the rails methods so they can handle all the domain specific functions...

Plus I don't know if ruby sprintf has it but running a class through it could be an easy way to expose all methods, some of which may not have...

@Thibaut changes made

I purposely used the `Util.to_number` method thinking that it would cover this aspect of it. Double-checking though the `Util` class has no tests at all. I'll create an Issue for...

This could likely be optimized after the fact, but for now I think this should just make it through, it seems to be some valid use cases held off by...

This is where I think an online tool would be beneficial that goes along with this, just thinking a really basic heroku type setup that just runs ruby and you...

This is a duplication of https://github.com/Shopify/liquid/pull/561 . This pull request does consider changes that have happened in Shopify since the other pull request was written. So next steps are to...

Needs to now support {% liquid %} and {% render %}. Added to TODO list