Mike Angell

Yes this changes behaviour, it disables scopes and environments from running default_proc. There is a lot of details about what this was about here https://github.com/Shopify/liquid/pull/1132#discussion_r318447148 and what it may break.

Basically it was designed around a single scope and over time environments have been added and other code and it has turned in to a block of code that is...

@tobi @pushrax @fw42 @ashmaroli I've modified this so default_proc support still exists, but this just simplifies `find_variables`

I would still love to get rid of the `|| !s.default_proc.nil?` support in future, but for now this just keeps the pull request to a single decision

It also fixes the new `static_environment` to be simple before it also starts ignoring nil values

I've actually got an idea how to do all this without causing issues for Shopify and other users of Liquid through some logging/instrumentation like @fw42 has suggested. It's pretty much...

This is currently on hold until I release usage tracking on `default_proc` usage. If nobody is using this then it makes sense to remove this so that `scope`, `environment` and...

I don't think this is trying to solve i18n but just provides a convenience method for formatting a number if you wanted to do so which even I've come across...

> In Shopify we should override this with a method that is i18n aware for the punctuation settings. Agree the defaults can be smarter when implemented internally. I've just made...

Other random stuff this can provide a simple solution for. https://community.shopify.com/c/Shopify-Design/Proper-formatting-for-shop-phone/m-p/118316 https://community.shopify.com/c/Shopify-Design/Formatting-shop-phone-for-use-in-notifications/m-p/108698 https://community.shopify.com/c/Shopify-Design/Format-Phone-Number/m-p/110194 ``` {% phone_number | divided_by: 10000 | format: 4, '-', '-' %} ```