odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

16.0 shopinvader base url

Open sebastienbeau opened this issue 1 year ago • 3 comments

Ready for review.

The module have receive a big refactor, in order to work without "shopinvader.variant"

Now urls

  • are generated only when the method "_update_url_key" is called (so it should be called before the export)
  • a flag is set on the record if something have changed to avoid useless recomputation
  • url key are global by default (same for all website), but the it's easy with an extra module to change this behaviour

The module shopinvader_product_url generate the url for the category and the product

TODO

  • [ ] add the redirect from product to category when deleting a product

Resolves #1373

sebastienbeau avatar Jun 26 '23 21:06 sebastienbeau

@sebastienbeau Tests were run again. No more error due to fastapi.

marielejeune avatar Jul 26 '23 13:07 marielejeune

@lmignon @marielejeune it's green

sebastienbeau avatar Jul 31 '23 15:07 sebastienbeau

@sebastienbeau https://github.com/shopinvader/odoo-shopinvader/pull/1399 Here you'll find my contribution to this PR following our discussions last week. Had to open a new PR as I couldn't push to akretion, feel free to cherry-pick :)

qgroulard avatar Aug 29 '23 10:08 qgroulard

already merged here : https://github.com/shopinvader/odoo-shopinvader/pull/1399

sebastienbeau avatar Jun 03 '24 16:06 sebastienbeau