odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

Published 20 hours ago • verified publisher icon shopinvader

[14.0][UPD] shopinvader partner binding: dedicated res.groups

Open acsonefho opened this issue 2 years ago • 4 comments

Add a new security group only allowed to bind partners. Binders doesn't need full access rights just to bind.

The existing security group implies this new one (so it stills compatible).

And as the ir.model.access is noupdate="1", I did a migration script.

acsonefho avatar May 20 '22 10:05 acsonefho

@shopinvader/shopinvader-maintainers Can you review and merge please?

acsonefho avatar Jun 14 '22 10:06 acsonefho

TBH I kind of feel that rather than a new group, we should allow any employee (base.group_user) to bind partners.

I don't think that we should allow every employee to bind partners.

acsonefho avatar Jun 14 '22 12:06 acsonefho

/ocabot rebase

rousseldenis avatar Jul 01 '22 07:07 rousseldenis

@acsonefho There is still an error on shopinvader now.

rousseldenis avatar Jul 01 '22 10:07 rousseldenis

@rousseldenis Do you have super-power to merge this please?

acsonefho avatar Nov 22 '22 13:11 acsonefho

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot avatar Nov 22 '22 13:11 shopinvader-git-bot

/ocabot merge minor

hparfr avatar Nov 24 '22 08:11 hparfr

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1290-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot avatar Nov 24 '22 08:11 shopinvader-git-bot

Congratulations, your PR was merged at 960daa3799bf00017a39e2deb9d14d6dd8ce6dac. Thanks a lot for contributing to shopinvader. ❤️

shopinvader-git-bot avatar Nov 24 '22 09:11 shopinvader-git-bot