odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

Published 20 hours ago • verified publisher icon shopinvader

[14.0] [FIX] shopinvader: don't create cart on search

Open ivantodorovich opened this issue 2 years ago • 4 comments

search shouldn't create a cart if missing.

This covers the case where a cart_id is present in the session, but it references a cart that's no longer a valid cart for our service.

ivantodorovich avatar Apr 25 '22 17:04 ivantodorovich

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot avatar Apr 30 '22 18:04 shopinvader-git-bot

Looking at this twice, while I think it's correct, we might be breaking existing frontend implementations. @sebastienbeau @rousseldenis @lmignon do you remember if this (getting a default cart on search) was done for a specific reason?

simahawk avatar May 12 '22 15:05 simahawk

ping @Cedric-Pigeon

lmignon avatar May 13 '22 06:05 lmignon

Ok to merge then? 👀

ivantodorovich avatar Oct 20 '22 11:10 ivantodorovich

I think @lmignon you can remove your blocking review, it should not raise any issue

sebastienbeau avatar Jun 14 '23 19:06 sebastienbeau

/ocabot merge patch

lmignon avatar Jun 15 '23 06:06 lmignon

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1281-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 15 '23 06:06 shopinvader-git-bot

Congratulations, your PR was merged at f024fda143108e712a11070c25a49d1b00f7ea59. Thanks a lot for contributing to shopinvader. ❤️

shopinvader-git-bot avatar Jun 15 '23 06:06 shopinvader-git-bot