[14.0] shopinvader_assortment: do not depend on search engine

[simahawk]

Forcing binding on recompute is kind of a stretch and it makes the dependency required.

From my POV as auto-binding already works w/ a cron it's unlikely that when you hit "Recompute" you won't get all bindings ready.

If you want to make sure you have all the bindings you can hit the new btn "Run assortment now". Also, when you have 1 backend per company you can use shopinvader_easy_binding, which allows you to create the binding on the fly as you tick the flag from the prod form.

@rousseldenis @Cedric-Pigeon what do you think? ~If you really want I can move the dep to a new glue module but IDT it adds any value. I could add a backward compat for force_recompute_all_binding_index conditionally to not alter existing behaviors but again IDT it adds any value.~

EDIT: added shopinvader_assortment_search_engine for backward compat.

[simahawk]

need to check some more things before this is ready

[acsonefho]

@rousseldenis @Cedric-Pigeon what do you think? If you really want I can move the dep to a new glue module but IDT it adds any value. I could add a backward compat for force_recompute_all_binding_index conditionally to not alter existing behaviors but again IDT it adds any value.

It could be great if you can keep the compatibility. Even if it doesn't add any value, keeping compatibility is important as it's already used in production. Thank you :)

[simahawk]

It could be great if you can keep the compatibility. Even if it doesn't add any value, keeping compatibility is important as it's already used in production. Thank you :)

can you have a look now? I added shopinvader_assortment_search_engine.

[simahawk]

@acsonefho fine for you? @ivantodorovich can you update your review?

[sebastienbeau]

As I do not have experience with this module, I let acsone team decide. @acsonefho @lmignon @Cedric-Pigeon

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.