odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

[IMP] In quotations menu, do not display carts

Open kevinkhao opened this issue 3 years ago • 1 comments

kevinkhao avatar Nov 26 '21 13:11 kevinkhao

@sebastienbeau

kevinkhao avatar Nov 26 '21 13:11 kevinkhao

/ocabot merge patch

sebastienbeau avatar Jun 14 '23 08:06 sebastienbeau

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1185-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 08:06 shopinvader-git-bot

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-1185-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 08:06 shopinvader-git-bot

Congratulations, your PR was merged at 24467654407868aa6ffdb091cd7034026c5451bc. Thanks a lot for contributing to shopinvader. ❤️

shopinvader-git-bot avatar Jun 14 '23 08:06 shopinvader-git-bot

Looks like a regression.

  1. it erase the default filter [('state', 'not in', ('draft', 'sent', 'cancel'))]
  2. there is an incompatiblity with shopinvader_quotation
    def write(self, vals):
        # Set the typology to "quotation" when the quotation is sent.
        # Normally there are two cases where this happens:
        # * When the :meth:`action_quotation_sent` is called.
        # * When a message is posted with context `mark_so_as_sent=True`.
        if vals.get("state") == "sent":
            vals["typology"] = "quotation"
    
    (https://github.com/shopinvader/odoo-shopinvader/blob/14.0/shopinvader_quotation/models/sale_order.py#L53C1-L59C43) typology=quotation (all state=sent) are not available anymore in Sales > Quotations
  3. filters become useless
                <filter
                    name="shopinvader_cart"
                    string="Shopinvader Carts"
                    domain="[('typology', '=', 'cart'), ('shopinvader_backend_id', '!=', False)]"
                />
https://github.com/shopinvader/odoo-shopinvader/blob/14.0/shopinvader/views/sale_view.xml#L34C1-L38C19

I suggest to revert this commit.

hparfr avatar Jul 12 '23 06:07 hparfr