odoo-shopinvader
odoo-shopinvader copied to clipboard
[IMP] In quotations menu, do not display carts
@sebastienbeau
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1185-by-sebastienbeau-bump-patch, awaiting test results.
It looks like something changed on 14.0
in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1185-by-sebastienbeau-bump-patch, awaiting test results.
Congratulations, your PR was merged at 24467654407868aa6ffdb091cd7034026c5451bc. Thanks a lot for contributing to shopinvader. ❤️
Looks like a regression.
- it erase the default filter [('state', 'not in', ('draft', 'sent', 'cancel'))]
- there is an incompatiblity with shopinvader_quotation
(https://github.com/shopinvader/odoo-shopinvader/blob/14.0/shopinvader_quotation/models/sale_order.py#L53C1-L59C43) typology=quotation (all state=sent) are not available anymore in Sales > Quotationsdef write(self, vals): # Set the typology to "quotation" when the quotation is sent. # Normally there are two cases where this happens: # * When the :meth:`action_quotation_sent` is called. # * When a message is posted with context `mark_so_as_sent=True`. if vals.get("state") == "sent": vals["typology"] = "quotation"
- filters become useless
<filter
name="shopinvader_cart"
string="Shopinvader Carts"
domain="[('typology', '=', 'cart'), ('shopinvader_backend_id', '!=', False)]"
/>
https://github.com/shopinvader/odoo-shopinvader/blob/14.0/shopinvader/views/sale_view.xml#L34C1-L38C19
I suggest to revert this commit.