odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

[14.0][FIX] shopinvader_delivery_carrier fix availability

Open acsonefho opened this issue 3 years ago • 8 comments

  • Revert 2 commits who do not work at all.
  • Apply a fix about delivery carriers availability to use success key
  • Apply a fix to execute the forcing of country/zip at the correct place.

It's better to directly check availability on the _match_address() who is at a lower level. https://github.com/odoo/odoo/blob/14.0/addons/delivery/models/delivery_carrier.py#L96

acsonefho avatar Nov 07 '21 19:11 acsonefho

@acsonefho Thank you for the fix. Can you fix the tests now so we can merge this PR. Thank you

lmignon avatar Feb 04 '22 16:02 lmignon

@shopinvader/shopinvader-maintainers Can you review and merge please?

acsonefho avatar Jun 14 '22 10:06 acsonefho

/ocabot merge minor

hparfr avatar Jun 15 '22 14:06 hparfr

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot avatar Jun 15 '22 14:06 shopinvader-git-bot

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

shopinvader-git-bot avatar Jun 15 '22 14:06 shopinvader-git-bot

/ocabot merge minor

rousseldenis avatar Jul 01 '22 10:07 rousseldenis

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1163-by-rousseldenis-bump-minor, awaiting test results.

shopinvader-git-bot avatar Jul 01 '22 10:07 shopinvader-git-bot

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1163-by-rousseldenis-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

shopinvader-git-bot avatar Jul 01 '22 10:07 shopinvader-git-bot

/ocabot merge minor

hparfr avatar Sep 19 '22 12:09 hparfr

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot avatar Sep 19 '22 12:09 shopinvader-git-bot

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot avatar Sep 19 '22 12:09 shopinvader-git-bot

Congratulations, your PR was merged at fd13819252e7c62d4b5b366732bea816741c9782. Thanks a lot for contributing to shopinvader. ❤️

shopinvader-git-bot avatar Sep 19 '22 12:09 shopinvader-git-bot