odoo-shopinvader
odoo-shopinvader copied to clipboard
[14.0][FIX] shopinvader_delivery_carrier fix availability
- Revert 2 commits who do not work at all.
- Apply a fix about delivery carriers availability to use
success
key - Apply a fix to execute the forcing of country/zip at the correct place.
It's better to directly check availability on the _match_address()
who is at a lower level.
https://github.com/odoo/odoo/blob/14.0/addons/delivery/models/delivery_carrier.py#L96
@acsonefho Thank you for the fix. Can you fix the tests now so we can merge this PR. Thank you
@shopinvader/shopinvader-maintainers Can you review and merge please?
/ocabot merge minor
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.
@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1163-by-rousseldenis-bump-minor, awaiting test results.
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1163-by-rousseldenis-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.
It looks like something changed on 14.0
in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1163-by-hparfr-bump-minor, awaiting test results.
Congratulations, your PR was merged at fd13819252e7c62d4b5b366732bea816741c9782. Thanks a lot for contributing to shopinvader. ❤️