odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

[14.0][ADD] shopinvader_mass_mailing 📨

Open ivantodorovich opened this issue 3 years ago • 9 comments

Exposes a mailing lists service to allow visitors to subscribe / unsubscribe from them.

ivantodorovich avatar Sep 21 '21 14:09 ivantodorovich

Done!

Tests are failing due to openupgradelib though:

  Running command git clone -q https://github.com/OCA/openupgradelib.git /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d
  Cloning https://github.com/OCA/openupgradelib.git to /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d
  Resolved https://github.com/OCA/openupgradelib.git to commit 871058afeb6dbd9b34314108b4a8ca6f3e0a9d9f
    ERROR: Command errored out with exit status 1:
     command: /opt/odoo-venv/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py'"'"'; __file__='"'"'/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-zshxn1wq
         cwd: /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py", line 5, in <module>
        import openupgradelib
      File "/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/openupgradelib/__init__.py", line 14, in <module>
        from importlib_metadata import version, PackageNotFoundError
    ModuleNotFoundError: No module named 'importlib_metadata'

Seems related to https://github.com/OCA/openupgradelib/pull/243

ivantodorovich avatar Sep 22 '21 13:09 ivantodorovich

yeah, I got the same issue and reported here https://github.com/shopinvader/odoo-shopinvader/issues/1111 CC @sbidoul

simahawk avatar Sep 22 '21 14:09 simahawk

Please restart test jobs

sbidoul avatar Sep 22 '21 15:09 sbidoul

BTW, this is also a set of REST services that would benefit of being independent of shopinvader (like helpdesk, event, etc). I think the only abstraction we need is a mechanism to determine the authenticated res.partner. Then these can go into OCA to benefit and attract broader community.

sbidoul avatar Sep 24 '21 07:09 sbidoul

I agree, but we could add this to the roadmap for v15.

simahawk avatar Sep 24 '21 07:09 simahawk

Ah, yes, v15 :rofl:

sbidoul avatar Sep 24 '21 08:09 sbidoul

@PierrickBrun is working on helpdesk case. When he will have a working version he can help on this

sebastienbeau avatar Oct 05 '21 16:10 sebastienbeau

TODO: review sudo changes

simahawk avatar Jan 28 '22 14:01 simahawk

rebased to solve conflicts

ivantodorovich avatar Oct 20 '22 11:10 ivantodorovich

/ocabot merge patch

sebastienbeau avatar Jun 14 '23 07:06 sebastienbeau

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1108-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 07:06 shopinvader-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 03 '24 12:03 github-actions[bot]