odoo-shopinvader icon indicating copy to clipboard operation
odoo-shopinvader copied to clipboard

[14.0][MIG] shopinvader_promotion_rule from 13.0

Open acsonefho opened this issue 3 years ago • 2 comments

Migration of shopinvader_promotion_rule from https://github.com/shopinvader/odoo-shopinvader/pull/894 (13.0)

Depends on

  • [ ] https://github.com/OCA/sale-workflow/pull/1583

Remove:

  • [ ] Entry in test-requirements

acsonefho avatar Aug 10 '21 13:08 acsonefho

@acsonefho Could you just add a technical commit with entry in test-requirements.txt in order to get tests greenify ?

rousseldenis avatar Aug 12 '21 08:08 rousseldenis

@shopinvader/shopinvader-maintainers Can you review and merge please?

acsonefho avatar Jun 14 '22 07:06 acsonefho

@acsonefho @acsonefho I am ok to merge this but we should just fix the typo (in french) in the dependency module : https://github.com/OCA/sale-workflow/pull/1583#discussion_r636339136

sebastienbeau avatar Jun 14 '23 07:06 sebastienbeau

@acsonefho Can tout remove the change test-requirement as dependency have been merged? Thanks

sebastienbeau avatar Jun 14 '23 10:06 sebastienbeau

@acsonefho Can tout remove the change test-requirement as dependency have been merged? Thanks

Done

acsonefho avatar Jun 14 '23 11:06 acsonefho

/ocabot merge patch

sebastienbeau avatar Jun 14 '23 13:06 sebastienbeau

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 13:06 shopinvader-git-bot

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 14:06 shopinvader-git-bot

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 14:06 shopinvader-git-bot

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot avatar Jun 14 '23 15:06 shopinvader-git-bot

Congratulations, your PR was merged at aade5b6168e9bf6a7fb33952f3b5e363e1f3273a. Thanks a lot for contributing to shopinvader. ❤️

shopinvader-git-bot avatar Jun 14 '23 16:06 shopinvader-git-bot