shop3 icon indicating copy to clipboard operation
shop3 copied to clipboard

Fix find-plans and find-plans-stack docstrings for translation to Texinfo

Open rpgoldman opened this issue 2 years ago • 5 comments

Use Markdown-style *'s for lists of parameters, so that sb-texinfo does a better job of translation. Even better would be to do something like Numpy-style docstrings that are readable as text or can be translated to good-looking Texinfo.

rpgoldman avatar Apr 15 '22 22:04 rpgoldman

How about the documentation of find-plans-stack? Is there anything there that can be improved? I'd also be interested in experimenting with it, if you consider it in a usable state.

ko56 avatar Apr 17 '22 21:04 ko56

find-plans-stack could use the same improvement. Checking the code, sb-texinfo claims to handle itemized lists if lines begin with a *. So that is worth a try.

Feel free to use find-plans-stack. It does not offer all of the different :which options that find-plans does, but for :which :first it is more efficient than find-plans.

rpgoldman avatar Apr 17 '22 22:04 rpgoldman

I just noticed this in explicit-search.lisp:

(defun find-plans-stack (problem &key domain (verbose 0) plan-tree (gc *gc*)
                                   (no-dependencies nil)
                                   repairable
                                   rationale
                                   (state-type :mixed state-type-supplied-p)
                                   (out-stream t)
                                   (which :first)
                                   analogical-replay
                                   (unpack-returns t)
                                   make-analogy-table)
  "Top level search function for explicit-state search in SHOP3.
Does not support the full range of options supported by SHOP3's
`find-plans-stack`.

Note the "find-plans-stack" in both the first and last lines. This also causes a problem in the manual.

ko56 avatar Apr 17 '22 23:04 ko56

Good catch! Thanks.

rpgoldman avatar Apr 18 '22 01:04 rpgoldman

I’m not sure whether sb-texinfo does cross-references. There’s not a ton of documentation. I’ll look at the code

rpgoldman avatar Apr 18 '22 01:04 rpgoldman