Stefan Holderbach
Stefan Holderbach
We have the option to use a history with sqlite based storage that keeps additional metadata compared to the basic text file that only llists the commands. ``` let-env config...
Sorry my bad, I got the logic mentally backwards.
A fresh set of eyes looking at this problem is absolutely welcome! @dbuch In my experimentation the resizing artifacts were especially pronounced when there was content close to the bottom...
I don't have strong opinions on this one. Will the right prompt still be hidden when the first line is full? Do we need to make this an option?
Let's get this in, I haven't fully validated the last line behavior but that can probably best evaluated with the nushell side with the different prompt configurations.
That sounds like a good idea to decouple some of that hard coded behavior on enter. I will try to take a look if there is stuff that might break....
Seems to work fine in my testing! Thanks for the elegant solution!
I will land it as is to allow users to play with it in the next (nushell) release. If we want to make a later breaking change we to the...
D'accord @fdncred. Yes with the right prompt it is pretty obvious. Don't know how much of an issue the resize on launch is with the old resize logic enabled. There...
Ah seems manageable. Let me quickly bash out a PR