Stefan Holderbach

Results 458 comments of Stefan Holderbach

Thanks for trying to address this! ~With the failed tests~ I am not sure if this breaks any assumptions. We also should test this behavior with different menus not just...

Thanks for giving this a shot and sorry that we didn't reply earlier. We picked up this PR in this weeks meeting, and wanted to share our conclusions. While I...

Do we need to thread them from `nu` to `nu-cmd-lang` or could we simplify things by having the `env!` invocation in e.g. `Version::new()`? Feels finicky in a different way (instead...

> We cannot use an `env!` inside `nu-cmd-lang` as we cannot control an the environment for it when building `nu` itself. Its build script only runs when everything else is...

Sounds like a job for `PipelineMetadata` :) i.e. when converting with `to json` attach a JSON pipeline metadata to the string and `table` can then decide to color, but everything...

With the current limitation that documentation comments have to occur on the same line, not sure how I feel about the expression part of the proposal. As an alternative design...

Re enum: I think the proposal gets pretty close to the lowest effort implementation of an enum but one that can only be used in command parameter types. I just...

Seems like a related manifestation of the issue in #11950 In both cases the garbage text appearing is part of the ANSI response containing the cursor position. (maybe the part...

Folks where adamant for us to allow assignment with an unparenthesized pipeline as the RHS expression. This makes it impossible to have expression style assignment as well without it becoming...

Good sleuthing that the pathiness may play into that, here! Vaguely related issues with `#` in strings leading to problems in other cases: - https://github.com/nushell/nushell/issues/10327 - https://github.com/nushell/nushell/issues/13810