why do we create twice the CrossvalidationSplitting objects

Open vigsterkr opened this issue 6 years ago • 5 comments

https://github.com/shogun-toolbox/shogun/blob/40f40f08b31b6cc73851201a4e1adf0ae7c39698/src/shogun/statistical_testing/internals/mmd/CrossValidationMMD.h#L198-L206

Oct 23 '19 11:10 vigsterkr

ok i've just realised that the second time it is just wrapped by a unique_ptr (i read it for some reason std::make_unique), still i'm not so sure why do we seed it twice? :)

Oct 23 '19 11:10 vigsterkr

@theartful why do we seed there twice the same object?

Oct 23 '19 11:10 vigsterkr

@vigsterkr It's a mistake on my part. Using std::make_unique and seeding once is enough.

Oct 23 '19 12:10 ghost

@theartful ok thnx for confirming! @lambday seems we need to update unit tests for xval mmd

Oct 23 '19 12:10 vigsterkr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apr 20 '20 15:04 stale[bot]