shogun icon indicating copy to clipboard operation
shogun copied to clipboard

remove EMachineType and related functions

Open vigsterkr opened this issue 7 years ago • 3 comments

https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/machine/Machine.h#L32

this enum needs to go because this will not be used (or usable when the plugin framework is in place).

vigsterkr avatar Jan 23 '19 14:01 vigsterkr

Hi Viktor, Should I take up this task of removing all enum data types with their integer value? Thanks

mrkarna avatar Feb 13 '19 04:02 mrkarna

@mrkarna try to give it a go and send in a pr

vigsterkr avatar Feb 13 '19 08:02 vigsterkr

@vigsterkr Do I need to remove only EMachineType or all the three enums (EMachineType, ESolverType and EProblemType). Thanks

mrkarna avatar Feb 13 '19 11:02 mrkarna