Concepts POC

[saatvikshah]

First stab at #4455 using Concepts for vectorized rng.

Currently this will only work with GCC which provides Concepts TS support based on certain flags. I've tried to make the impl compatible with either Concepts TS or C++20 concepts.

[karlnapf]

Awesome initiative! I will check this out a bit more soon, first need to read up on Concepts I guess ;)

[saatvikshah]

FYI, Throw-lists(eg. void fn() throw(ShogunException)) which are used in a number of places have been deprecated in C++11 and removed from C++17 onwards ref. Hit this majorly along with a few other errors when I was trying to compile with C++17 support.

[gf712]

FYI, Throw-lists(eg. void fn() throw(ShogunException)) which are used in a number of places have been deprecated in C++11 and removed from C++17 onwards ref. Hit this majorly along with a few other errors when I was trying to compile with C++17 support.

Yup, @vigsterkr started removing all the dynamic exceptions in the cpp17 branch!

[iglesias]

Any preference to organize merging this and the other PR that triggered this experiment, @saatvikshah1994? I am guessing it may make sense to merge the other one first and then rebase the changes here onto it. Still it is fine by me to merge this one directly to the feature branch.

[saatvikshah]

@iglesias Yes, would prefer to merge the other one first(#4437) and then rebase and merge this. But I'm not so sure what is the plan with respect to #4437 ?

[iglesias]

All CI tasks good. @saatvikshah1994, I can't merge from here due to the conflicts marked above. Would you mind doing the manual job to fix the conflicts? I will merge afterwards.

[saatvikshah]

Sure @iglesias I'll also add more compilation guards to prevent any future issues.

[karlnapf]

Reported as spam

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.