shoes3 icon indicating copy to clipboard operation
shoes3 copied to clipboard

EditLine is misaligned

Open IanTrudel opened this issue 7 years ago • 5 comments

EditLine is slightly up compared to other side-by-side widgets. Other EditBox and such may suffer from this too.

image

IanTrudel avatar Mar 30 '17 13:03 IanTrudel

It's theme 'enhancement`. The top line is fine on Linux (two different themes/platorms) and if I remember OSX, the edit_line is less tall than the buttons. The cobbler code could use some margins/centering between the buttons and the edit line to better fit the horizontal space which would hide the themes 'help', and would look better for all.

ccoupe avatar Mar 31 '17 05:03 ccoupe

It's not correct as far as Windows theme goes. There is 1px difference. The second flow below would be the expected behaviour.

image

Shoes.app(width: 350, height: 150) do
   para "———————————————————\n"
   
   flow do
      button "one"
      edit_line
      button "two"
   end
   
   para "———————————————————\n"
   
   flow do
      button "one"
      edit_line margin: 1
      button "two"
   end
end

IanTrudel avatar Mar 31 '17 18:03 IanTrudel

Why do you believe buttons are the same height as edit_lines? They are not even close to the same height on OSX. Adding that margin would ruin the OSX layout. Fix the Windows theme.

ccoupe avatar Apr 01 '17 01:04 ccoupe

Fix the Windows theme.

Yes, seems like the logical thing to do.

IanTrudel avatar Apr 01 '17 02:04 IanTrudel

Same misalignment problem on FreeBSD.

Shoes: image

FCITX Configuration (QT): image

Characters table (GTK) image

IanTrudel avatar Sep 28 '17 19:09 IanTrudel