shoes-deprecated icon indicating copy to clipboard operation
shoes-deprecated copied to clipboard

Replace hpricot with nokogiri for default HTML parser

Open rposborne opened this issue 12 years ago • 6 comments

From the hpricot git repo

Hpricot has ended. Please consider an alternative like nokogiri.

rposborne avatar Oct 31 '12 15:10 rposborne

Considering how we're kind of "phasing out" shoes3, and looking into a jruby-based shoes4, I think this can be solved. However, I don't have as much experience in the new jruby version as I'd like, so we might still be using hpricot.

James Gifford cell: 2162238574

On Wed, Oct 31, 2012 at 11:15 AM, rposborne [email protected]:

From the hpricot git repo

Hpricot has ended. Please consider an alternative like nokogiri.

— Reply to this email directly or view it on GitHubhttps://github.com/shoes/shoes/issues/223.

jrgifford avatar Oct 31 '12 15:10 jrgifford

I had tried to do this a few times, there's even a branch somewhere. It's not super simple to replace.

steveklabnik avatar Oct 31 '12 16:10 steveklabnik

I can't find the branch. Anyway, yeah, super :+1:, feel free to implement this.

steveklabnik avatar Oct 31 '12 16:10 steveklabnik

Shoes 4 doesn't parse HTML yet, but when it does, it'll use nokogiri.

wasnotrice avatar Oct 31 '12 17:10 wasnotrice

Where can i find the the shoes 4 branch?

rposborne avatar Nov 01 '12 12:11 rposborne

https://github.com/shoes/shoes4

wasnotrice avatar Nov 01 '12 12:11 wasnotrice