sequitur icon indicating copy to clipboard operation
sequitur copied to clipboard

Adding Batch support for LSTM_AE

Open Mustapha-AJEGHRIR opened this issue 3 years ago โ€ข 4 comments

Hello there, I have added batch support for the LSTM_AE. I don't know if this is 100% compatible with the library, but I'm only using the LSTM_AE in one of my projects, so I decided to contribute ๐Ÿ˜ƒ . Thanks

Mustapha-AJEGHRIR avatar Aug 04 '22 19:08 Mustapha-AJEGHRIR

Preparing review...

adrenaline-pr-bot[bot] avatar Dec 21 '23 01:12 adrenaline-pr-bot[bot]

PR Analysis

(review updated until commit https://github.com/shobrook/sequitur/commit/cf0a26130961ca06a33f9f300eefb61a3bef0458)

  • ๐ŸŽฏ Main theme: Batch Support Addition
  • ๐Ÿ“ PR summary: This PR adds batch support to the LSTM_AE model in the sequitur library. The changes mainly involve modifying the forward methods of the Encoder, Decoder, and LSTM_AE classes to handle batched inputs.
  • ๐Ÿ“Œ Type of PR: Enhancement
  • ๐Ÿงช Relevant tests added: No
  • โœจ Focused PR: Yes, the PR is focused as all changes are related to the addition of batch support for LSTM_AE.
  • ๐Ÿ”’ Security concerns: No

PR Feedback

  • ๐Ÿ’ก General suggestions: The PR is generally well-structured and the changes are clear. However, it would be beneficial to add tests to verify the new functionality. Additionally, it would be good to ensure that these changes are compatible with the rest of the library, as the contributor mentioned uncertainty about this.

adrenaline-pr-bot[bot] avatar Dec 21 '23 01:12 adrenaline-pr-bot[bot]

Persistent review updated to latest commit https://github.com/shobrook/sequitur/commit/cf0a26130961ca06a33f9f300eefb61a3bef0458

adrenaline-pr-bot[bot] avatar Dec 21 '23 01:12 adrenaline-pr-bot[bot]

Persistent review updated to latest commit https://github.com/shobrook/sequitur/commit/cf0a26130961ca06a33f9f300eefb61a3bef0458

adrenaline-pr-bot[bot] avatar Dec 21 '23 01:12 adrenaline-pr-bot[bot]