Max Loeb

Results 89 comments of Max Loeb

@koenpunt @jpfuentes2 please review

Well, my argument is that type matters. This library seems to implicitly agree with me, as it makes a point of casting type when doing a find. Is your argument...

@koenpunt Are we waiting on something?

Thanks for the comments. 👍 I'm happy with this if you are.

> if you really want this feature included in the library before then Nah, I don't think there's any rush; in the meantime, I can just continue to access the...

Merged latest. Still no rush, or anything, but it should be ready for next release.

> In that case, I might consider merging this when making a future release that includes breaking changes. I don't plan on it soon though. And if the plan is...

Not sure I follow. I don't use Lighthouse, and I'm not familiar with it. What does it have to do with what I'm doing in this PR?

I see. Lighthouse implements its own high-level query flow, and uses `DocumentValidator:validate` directly. In the meantime, I modified my own code to just disable validation on production (I use persisted...