Max Loeb

Results 83 comments of Max Loeb

> I've got an idea - every $tokens->tryConsumeTokenType(Lexer::TOKEN_PHPDOC_EOL); in TypeParser should be replaced by a special method on TokenIterator that would return an array of comments which we could use...

Moving this back to draft, as I'm discovering general problems around format-preserving of single line vs inline comments. Hopefully won't take too long to sort out...

> general problems around format-preserving of single line False alarm. I confirmed behavior against Nikic parser, and the behavior with comments in this branch seems to be correct. I had...

> About @param /* TODO: remove */ array $data - I don't think we want to support this because the comment is not part of the type, it precedes it....

Well, that's certainly a fair point! I don't think it will reduce complexity at all, but obviously if it breaks PHP it will have to go. Let me see what...

Here you go: bfa599138b9a097073663319cb17a31d4e7f402e

Sigh. I forgot I can't just fork the parser, because you have everything all wrapped up in a phar.

@ethernidee thanks, I appreciate the words of encouragement. Let me summarize the situation: 1. I opened a PR with a very simple solution, which was to ignore array shape comments...

> multiline comments are necessary everywhere Unfortunately, we've discovered that multiline comments aren't legal inside a doc block comment (PHP can't parse them).