PySolFC icon indicating copy to clipboard operation
PySolFC copied to clipboard

Cardset loading error messages are uninformative.

Open Alucard648 opened this issue 1 year ago • 4 comments

I find that cardset loading error messages, usually caused by either failure to load image file, or bad config, are quite uninformative, oftenly leaving cardset maker clueless about what he did wrong. error And that is generic message for all cardset loading errors.

Alucard648 avatar Nov 06 '24 12:11 Alucard648

Can you provide a couple sample cardsets that would trigger this error?

joeraz avatar Nov 07 '24 00:11 joeraz

Just try to remove an image from cardset and try to reload it in PySol. You get the same message, regardless what file was not found.

Alucard648 avatar Nov 07 '24 02:11 Alucard648

The error wasn't being caught, so I added an error check, which leads to the message that should be displayed.

Though I should probably set it up so a cardset with a missing required card image just doesn't get recognized.

joeraz avatar Nov 09 '24 02:11 joeraz

I think, attempt to load cardset with missing image file should output error message like "Failed to find file ####" so cardset maker can correct this by putting in necessary file.

Alucard648 avatar Nov 09 '24 15:11 Alucard648