shlomif
Reordering Favorite games
Currently, the menu has only entries to Add/Remove a game to the list of favorite games.
Reordering this list (eg. moving some games up/down) would be cumbersome via multiple select/remove/add-operations, or finding + directly editing options.cfg
So, I propose to add menu-entries to move the current game up/down the favorites-list.
Under normal circumstances, this wouldn't be tricky to add. However, there is one scenario which I'd need to account for if I wanted to add this - if the list of favorite games becomes excessively long, PySol will automatically start to group them in the same manner as the Select/All Games by Name menu. This seems like something unlikely to happen, but I did have to fix that once after a bug report from someone who assigned four columns worth of favorite games, so I have to consider this situation.
How should manual sorting of the favorites work in this case? Or would it be better to just simply auto-alphabetize the list?
I would sort games first by category/cardset, eg. french/tarock/mahjongg/shisen-sho etc. and let the player order his favorites inside those categories.
Also, you could simply put a limit on the length of the favorites-list...
Main issue with that approach is that about 70% of the games in PySolFC are French category. Most people would just have all the games there.
We'd need to avoid situations where the submenu gets too big.
70% of the games in PySolFC are French category.
ok - sub-divide into freecell-type, spider-type etc.
avoid situations where the submenu gets too big.
well, when it is about to happen, just disable the menu-entry for 'add'
Other idea: selection with filter-settings, and criteria such as 'show games not played yet', 'games with mostly-skill or skill-only', 'only games with at least one win', 'games with comments' ...
It's difficult due to the fact that the limit is based on screen size rather than just a set number - it's all about screen space. Might have to think about this one more.
There is already a game filter option in the form of the Advanced Search feature - go to Select/All Games, choose the Search tab, press the ellipsis next to the search field, and you can search on a number of different criteria - this does not include searching based on player-specific context like favorites or games won/played. I'd have to look into what would be involved in getting access to player data in the game search.