Pysolfc import function

[donnsd]

For the pysolfc penguin game, when you export a game and then import the exported game, the results are wrong. I think the import function is broken for the penguin game. It appears that export is correct. I cannot import a user generated game either. Thanks, Don.

[joeraz]

Testing this, it looks like the game that gets exported is logically the same game, but the base rank is set to ace, and all of the other cards' ranks are adjusted accordingly.

I haven't really dealt much with the import/export logic, but it seems to use some of the same logic as the solvers.

@shlomif - Before I change anything, can you confirm if the solvers use the _card2str_format method in hint.py, and if so, is there a specific reason it's written that way?

[shlomif]

On Sun, 27 Nov 2022 08:03:51 -0800 "Joe R." @.***> wrote:

Testing this, it looks like the game that gets exported is logically the same game, but the base rank is set to ace, and all of the other cards' ranks are adjusted accordingly.

I haven't really dealt much with the import/export logic, but it seems to use some of the same logic as the solvers.

@shlomif - Before I change anything, can you confirm if the solvers use the _card2str_format method in hint.py, and if so, is there a specific reason it's written that way?

yes, they are using it. "self.base_rank" was added for Penguin.

--

Shlomi Fish https://www.shlomifish.org/ https://is.gd/KNvczZ - The FSF Announces New Versions of the GPL

When Chuck Norris disses your product, it’s not good publicity, even though you can bet he’ll get the name right. — https://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - https://shlom.in/reply .

[joeraz]

Thanks. I'll look into adding an alternate version of that logic for the import/export.