PySolFC icon indicating copy to clipboard operation
PySolFC copied to clipboard

Clean up images

Open MorsMortium opened this issue 2 years ago • 6 comments

There are many images that have white pixels around them. They look bad with darker themes. Screenshot_20220407_125727 Screenshot_20220407_130313 Screenshot_20220407_130346

MorsMortium avatar Apr 07 '22 11:04 MorsMortium

I can take a stab at this, but my image editing skills are pretty basic. Would need someone on the team with better image editing skills to perfect this.

Though as for the toolbar icons, you may be able to switch those out for a style that looks better with the dark interface. In 2.15, this can be done by going to Options -> Toolbar -> Icon Style, but in older versions, you can change the toolbar_style value in the options.cfg to change the icon style to a different one (i.e. crystal or human).

joeraz avatar Apr 09 '22 01:04 joeraz

On arch 2.14.1 is packaged, so I didn't see the option, but editing the config, I saw that crystal also needs cleanup: crystal But human is perfect, so that's what I'll use: human There are newer icon styles, but they're added in 2.15, so I don't have them. On the editing itself I recommend only editing the highest resolution icons and downscaling from that, and the same with the jester/joker images, to make it less work.

MorsMortium avatar Apr 09 '22 12:04 MorsMortium

@MorsMortium how did you get PySol to use gtkTtk?

daemonspudguy avatar Apr 11 '22 17:04 daemonspudguy

I checked the icon styles added in 2.15 and they don't appear to have this issue (though Remix uses pure black outlines, so I went ahead and added a white version of it for better contrast with a darker theme).

I was able to fix the Bluecurve icons by re-copying the icons from a copy of the original icon library. I don't have the original library for Crystal (or at least not the version the previous developers used) - I'm going to need that anyway for another planned change, so I'll have to get back to that one later. The jester images will need to be done manually, and while I tried briefly, I always ended up cutting off more than I needed to.

joeraz avatar Apr 12 '22 03:04 joeraz

I updated the joker images to try and remove the borders. Though someone with better image editing skills than me could probably tweak them further to make them look even better.

joeraz avatar May 01 '22 22:05 joeraz

With today's commits, I updated to the newest version of the crystal icon set, which should resolve the last of this bit of image cleanup. Though I'm going to leave this ticket open in case someone with even better image manipulation skills wants to take a stab at cleaning the joker images up even better.

joeraz avatar Jun 03 '22 03:06 joeraz

A bit late, but i rechecked every icon style and image, and all looks good. Thanks, and great work!

MorsMortium avatar Mar 14 '23 12:03 MorsMortium