PySolFC icon indicating copy to clipboard operation
PySolFC copied to clipboard

[TODO] Verify that the games' save/load feature is working before release

Open shlomif opened this issue 6 years ago • 3 comments

The conversion to https://www.attrs.org/en/stable/ may have broken it.

shlomif avatar Jul 26 '19 13:07 shlomif

Indeed, restoring of games failed due to refactoring with attrs. Fixed it on occasion, commit 97267e9.

lufebe16 avatar Sep 26 '19 11:09 lufebe16

@shlomif This worked so far.

But when I think about it deeper, a big black hole opens, that swallows all my statistics and all my games collected over years! - We would have to provide migration code.

The easier way to get back to a to a running solution would be to revert these changes, at least regarding moves,statistics and gstatistics structs.

lufebe16 avatar Sep 27 '19 05:09 lufebe16

New and old formats seem to be compatible on import, only the code throws an assert. So this could be fixed by ignoring some checks. Then old games from the users collections are still readable. Commit 92f2d5f.

lufebe16 avatar Sep 27 '19 09:09 lufebe16