ngx-modialog icon indicating copy to clipboard operation
ngx-modialog copied to clipboard

CLose button does not show up using context.showClose = true context field.

Open ddreamscu opened this issue 7 years ago • 2 comments

  • I'm submitting a ... [x ] bug report [ ] feature request [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug? Report a Bug:

  • What is the current behavior?

When using custom modal to display a Component, after setting the context.showOpen = true, the close button doesn't show up.

  • What is the expected behavior?

A close button (a cross perhaps?) should show up as part of the modal.

  • What is the motivation / use case for changing the behavior?

I would like to have a x displayed on the upper right corner of the screen.

  • Please tell us about your environment:
  • Angular version: 2.0.0-beta.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

ddreamscu avatar Mar 04 '17 16:03 ddreamscu

+1

philippegabert avatar Mar 26 '17 11:03 philippegabert

I get a close button:

    const confirmation = this._modal.confirm()
      .isBlocking(true)
      .showClose(true)
      .size('lg')
      .title('Please confirm')
      .open()

Except it is in the wrong place: confirm modal

rmcsharry avatar Oct 31 '17 19:10 rmcsharry