Shlomi Assaf
Shlomi Assaf
This is a change to the bootstrap plugin, if anyone wants to give it a shot I will gladly accept PRs. If not I will try to find time but...
Hi @CaselIT ``` ts function bubbleNonAncestorHandlerFactory(element: HTMLElement, handler: (event) => void) { return (event) => { let current = event.target; do { if ( current === element ) { return;...
As for why it's closing, It happening because you remove the Button element before the event handler is invoked. i.e: when `bubbleNonAncestorHandlerFactory` is invoked the element.target has no parent node...
`element.contains` will do a check when it was already removed, same async issue here. One thing that will solve this easily is looking at `event.path` which is a snapshot of...
I agree, everything you said it true. But it has to be tested against multiple browsers and on mobile, to make sure the element we get is the right one....
This is exactly the complexity I want to avoid. Having this will create an unexpected behaviour, sometimes removing a clicked button from the form will close the form, sometimes not......
It's better be a bug, just edit this issue to have a proper title
The demo for this project is using webpack, there shouldn't be any issues. I need more information
@anudwigna The **demo** application located within this project at the **src** directory is based on Webpack. There are custom elements loaded within that demo. This is the code used for...
@iherbivore how did you test this scenario? It's probably a bit deeper then animation since the animation process is guarded by a timeout, see [source code](https://github.com/shlomiassaf/angular2-modal/blob/1953e3f309761354f67caebb11348b625ca166f8/src/components/angular2-modal/overlay/overlay.component.ts#L182)