FileHeader icon indicating copy to clipboard operation
FileHeader copied to clipboard

custom variable not working after last_modified_time

Open gtataranni opened this issue 8 years ago • 2 comments

I found a bug appearing in very specific conditions where a custom {{variable}} value is not resolved, and it is happening when the variable {{variable}} is on the same line as {{last_modified_time}} .

To reproduce the bug:

  • template used
// Made by {{full_name}}
// Mail:   <{{email}}>
//
// Started on  {{create_time}} {{full_name}}
// Last update {{last_modified_time}} {{full_name}}
  • settings
"Default": {
        "full_name": "Name SURN"
    },
  • add new template to existing file. Result is ok
// Made by Name SURN
// Mail:   <[email protected]>
// 
// Started on  Wed Jul 06 14:19:41 2016 Name SURN
// Last update Wed Jul 06 14:19:41 2016 Name SURN
this is a test
  • modify and save. This is the result
// Made by Name SURN
// Mail:   <[email protected]>
// 
// Started on  Wed Jul 06 14:19:41 2016 Name SURN
// Last update Wed Jul 06 14:28:25 2016  {{full_name}}
this is a test 2

gtataranni avatar Jul 06 '16 12:07 gtataranni

Yeah. Actually FileHeader will find last_modified_time and last_modified_by using regex(got from header) line by line, and it will only focus on the string {{last_modified_time}} and leave the other string in that line the same.

I'll try to fix it. Thanks!

shiyanhui avatar Jul 06 '16 15:07 shiyanhui

Any news about this?

citosid avatar Oct 10 '16 15:10 citosid