materialsteppers icon indicating copy to clipboard operation
materialsteppers copied to clipboard

Last onNextButtonHandler method is never called

Open apache05 opened this issue 8 years ago • 11 comments

Hi shivasurya. Congratulations about your materialstepper. I'm using it and I've realize that the onNextButtonHandler method of the last stepper is never called. Is it a bug or I'm doing something wrong?

Thanks

apache05 avatar Mar 05 '16 19:03 apache05

I'll check that and get to you back.actually my example code was working till the last Stepper and shows alert dialog.may be that can help you. https://github.com/shivasurya/materialsteppers/tree/master/example/src/main/java/stepper/ivb/com/example

shivasurya avatar Mar 06 '16 03:03 shivasurya

Hi Shivarsuya. Your example works fine but try to call onNextButtonHandler in the last stepper. It's never reached. :(

apache05 avatar Mar 08 '16 09:03 apache05

share your code base ! let me try it out.

shivasurya avatar Mar 11 '16 08:03 shivasurya

Hi Shivarsuya. I've edited your code example. Only three fragments are launched (textFragment -> FormFragment->Instruction). The Instruction's onNextButtonHandler is never called. Check it out please.

materialsteppers-ruben.zip

apache05 avatar Mar 12 '16 08:03 apache05

it's serious bug :+1: thanks for reporting ! let me update it soon.as you said the last fragment onNextButtonHandler() is never called.

shivasurya avatar Mar 18 '16 08:03 shivasurya

https://github.com/shivasurya/stepperTest/commit/5810a9c3fa837d7b4d3a00077e790900727a502c fixed the issue - in another repo - will sync soon in next update soon

shivasurya avatar Mar 18 '16 09:03 shivasurya

Thanks!

apache05 avatar Mar 18 '16 11:03 apache05

any other feedbacks to improve ? for communication between fragments i'll update it will Bundle whether onNextButtonHandler is useful ? to validate your UI inputs/Network Service/Long running operations in background.(this design pattern is adaptive for end users ?)

any further inputs will be helpful.i'm modifying some basic and adding new stepper components based on material design docs.

shivasurya avatar Mar 18 '16 15:03 shivasurya

So far everything else is fine. Good job.

apache05 avatar Mar 19 '16 17:03 apache05

Current clone or download of project does not have this fix

ColinWa avatar Dec 20 '16 13:12 ColinWa

Please can u update with the fix

Osmandiyaka avatar Oct 31 '18 19:10 Osmandiyaka