setup-php icon indicating copy to clipboard operation
setup-php copied to clipboard

Improve error reporting when ubuntu launchpad is down?

Open SystemKeeper opened this issue 10 months ago • 2 comments

Describe the feature

Today ubuntu launchpad went into maintenance (see https://ubuntu.social/@launchpadstatus/112286753813553221) and installation of php failed because of that:

image

I am wondering if it would be possible to output a message that indicates why the installation failed in that case?

Version

  • [x] I have checked releases, and the feature is missing in the latest patch version of v2.

Describe alternatives

I guess there's no alternative instead of guessing what happens.

Are you willing to submit a PR?

Yes in general, but never looked at the setup-php code in more detail.

SystemKeeper avatar Apr 18 '24 15:04 SystemKeeper

@SystemKeeper

I plan to add a mirror for the PPA we use as a fallback to avoid this in future.

shivammathur avatar Apr 21 '24 11:04 shivammathur

Hi there, we experienced the same issue last week. it's great to see that you are working on this, thank you @shivammathur 🙏

rukaelin avatar Apr 24 '24 15:04 rukaelin

Hi i have similiar issue

image

thank you @shivammathur

samansupriadi avatar Jun 10 '24 16:06 samansupriadi

@samansupriadi Please create a separate issue with details about your workflow.

shivammathur avatar Jun 10 '24 17:06 shivammathur

Hello, thank you for your work on this repo. It is very much appreciated. 🙏

Major PPA outage today triggering fail. Acknowledged by Canonical here.

Although you said:

I plan to add a mirror for the PPA we use as a fallback to avoid this in future.

I think this ticket is more about showing some logs when an incident like this occurs. Right now, we have to trigger by changing shivammathur/[email protected] to shivammathur/setup-php@verbose@verbose

Then I see a massive dump that includes the one line I care about:

Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1::81). - connect (101: Network is unreachable)

Would be nice if error was shown without verbose.

dac-humi avatar Jun 12 '24 17:06 dac-humi

@dac-humi

I understand that, but to display that error in the apt-get update command it is required to change how logs are piped in the action and that change is not trivial, and I cannot work on that right now.

It would be much easier for me to maintain a fallback mirror for the PPA.

shivammathur avatar Jun 12 '24 20:06 shivammathur

Added a fallback mirror in 2.31.0.

shivammathur avatar Jun 24 '24 02:06 shivammathur