setup-php icon indicating copy to clipboard operation
setup-php copied to clipboard

Composer php version

Open watarukura opened this issue 2 years ago • 3 comments


name: 🐞 Bug Fix, ⚙ Improvement or 🎉 New Feature about: You found a bug, want to improve something or add a new feature labels: bug or enhancement


A Pull Request should be associated with a Discussion.

close https://github.com/shivammathur/setup-php/issues/629

Related discussion:

Description

This PR add args version-file, and pick up PHP version from composer.json or .tool-versions or .php-version.

In case this PR introduced TypeScript/JavaScript code changes:

  • [x] I have written test cases for the changes in this pull request
  • [x] I have run npm run format before the commit.
  • [x] I have run npm run lint before the commit.
  • [x] I have run npm run release before the commit.
  • [x] npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • [ ] I have checked the edited scripts for syntax.
  • [ ] I have tested the changes in an integration test (If yes, provide workflow YAML and link).

watarukura avatar Aug 31 '22 04:08 watarukura

https://github.com/shivammathur/setup-php/issues/629 thank you for advice, but I could not implement pickup latest version from multiple version set. (ex: "^8.0|^8.1")

watarukura avatar Aug 31 '22 04:08 watarukura

@watarukura Thanks for the PR. I will have a look this weekend.

shivammathur avatar Aug 31 '22 12:08 shivammathur

Codecov Report

Merging #639 (ae4a007) into master (e04e1d9) will decrease coverage by 2.34%. The diff coverage is 23.52%.

@@             Coverage Diff             @@
##            master     #639      +/-   ##
===========================================
- Coverage   100.00%   97.65%   -2.35%     
===========================================
  Files            6        6              
  Lines          538      555      +17     
  Branches        80       85       +5     
===========================================
+ Hits           538      542       +4     
- Misses           0       12      +12     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/utils.ts 89.76% <23.52%> (-10.24%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 11 '22 04:09 codecov[bot]

Sorry, I'll retry, if I can understand this errors...

watarukura avatar Oct 26 '22 05:10 watarukura