Shishir

Results 64 comments of Shishir

ping @nicholasjackson @judithpatudith

@judithpatudith Thanks! Also, adding @Blake since he is helping me out on an internal (Roblox) slack channel. Looks like the demo repo is using an older consul version `consul 1.6.1`...

@judithpatudith Looks like if I update `consul` container to `consul 1.9.5` (current version) the issue goes away. I updated the `consul version` to `1.9.5` [`here`](https://github.com/hashicorp/consul-demo-traffic-splitting/blob/master/Dockerfile-consul#L3) Followed by: ``` 1. docker-compose...

@judithpatudith @karl-cardenas-coding Looks like the issue is **not** fully resolved, and the `envoy` container images in the repo also needs to be updated? I am going to reopen the issue...

@t-hale Sorry I am not actively working on this project right now, due to other competing priorities. Feel free to pick it up if you like. I ll try to...

> I really like what this PR is capturing. Some nitpicks: I think calling `IneligibleReason` rather than `Description` more tightly aligns with your intent, since your implementation requires it be...