gopsutil
gopsutil copied to clipboard
shirou
Builds for netbsd arm fail with `undefined: cpuTimes`
Describe the bug
NetBSD builds on ARM started to failed after version 3.23.8
To Reproduce
env GOOS=netbsd GOARCH=arm go build ...
# github.com/shirou/gopsutil/v3/cpu
../../../pkg/mod/github.com/shirou/gopsutil/[email protected]/cpu/cpu_netbsd.go:45:14: undefined: cpuTimes
../../../pkg/mod/github.com/shirou/gopsutil/[email protected]/cpu/cpu_netbsd.go:70:14: undefined: cpuTimes
Expected behavior
Successful builds of netbsd/arm targets
netbsd/arm has never been supported, this was just falling back to the functions returning a common.ErrNotImplementedError in cpu/cpu_fallback.go before #1530.
Please report back if copying cpu/cpu_openbsd_arm.go to cpu/cpu_netbsd_arm.go fixes the issue, it should build but check if it returns coherent results.
@Lomanic Thanks for the quick reply! That does resolve the build error. In my case the fallback error was preferable to a build failure (or nonsense results). I haven't been able to test this on a recent NetBSD to confirm.
Does this mean that you have confirmed that cpu_netbsd_arm.go copied from cpu_openbsd_arm.go works fine? If so, we can make a PR to add that file. This will avoid build failures.
Switching to the previous fallback method would resolve this, but I haven't had a chance to review the results on NetBSD. The bigger issue is the build failure (rather than support for the OS).