LootBeams icon indicating copy to clipboard operation
LootBeams copied to clipboard

Mod causes significant 20 to 40% render performance drop

Open Kaleidio opened this issue 3 years ago • 9 comments

Not sure if optimization routes are available, but I go from 500 fps to 350 fps when an item is rendered. the lower number is with loot beams installed.

Kaleidio avatar Dec 14 '21 21:12 Kaleidio

Consider utilizing the renderers provided by Better Beacon Effects mod, which brings back the two dimensional texture pillar renderer for beacon beams, which is inherently an optimization. Would require compat code.

Kaleidio avatar Jan 17 '23 11:01 Kaleidio

Over a year late to this but i recently found the problem. It was due to us not caching tooltips. The "beacon beams" we render are literally 4 raw GL quads, they are as optimized as can be.

amoooooo avatar Mar 11 '23 18:03 amoooooo

Ah understood, that makes a lot of sense as well. Any chance it would get patched for 1.16.5?

Colin-J-Wood avatar Mar 11 '23 19:03 Colin-J-Wood

eh if i get around to it. 1.16.5 is mostly a dead version for the most part so i've kind of given up with it lol

amoooooo avatar Mar 11 '23 19:03 amoooooo

sadly my modpack is stuck in 1.16.5 due to mod choice so I have no other reason to want this mod back.

Kaleidio avatar Mar 11 '23 19:03 Kaleidio

I can look into backporting it into 1.16, already did it for 1.18

JustAHuman-xD avatar Mar 18 '23 21:03 JustAHuman-xD

Over a year late to this but i recently found the problem. It was due to us not caching tooltips. The "beacon beams" we render are literally 4 raw GL quads, they are as optimized as can be.

I understand you may not have interest in making compat for the renderer, but Better Beacon Effects is only 1 billboarded quad instead of 4.

Kaleidio avatar Mar 19 '23 02:03 Kaleidio

no it isnt :D https://github.com/AlexDorian7/BetterBeaconEffects/blob/main/src/main/java/org/AlextronStudios/BetterBeaconEffects/OldBeaconTileEntityRender.java#L336 Look at how many times addQuad is called.

amoooooo avatar Mar 19 '23 11:03 amoooooo

Wow, that's surprising and very disappointing, the mod claims to be faster by using less quad calls on the curseforge page. They must be pulling off the classic effect by overlaying several quads instead of using a shader or texture...I'm uninstalling that mod

Kaleidio avatar Mar 19 '23 12:03 Kaleidio