cli icon indicating copy to clipboard operation
cli copied to clipboard

consolidate various field validations with what is already done in shipwright-io/build

Open gabemontero opened this issue 3 years ago • 1 comments

Started seeing some overlap in validation individual PRs are doing in this repo with what is already done is spots like https://github.com/shipwright-io/build/blob/main/pkg/validate/

Do we just halt / remove doing analogous validations in the CLI?

Or do we create a common shared package of validations that can be used in both repos?

See https://github.com/shipwright-io/cli/pull/35/commits/a5a8cd8fb4b5004a8be56d4d609b29f8e470f220#r703641375 for a specific discussion thread / example.

gabemontero avatar Sep 07 '21 16:09 gabemontero

An item of concern - we need to ensure the validations we need to consume are exportable from the validate package. This can be tested now that cli depends on the build module.

adambkaplan avatar Mar 23 '22 13:03 adambkaplan