cli icon indicating copy to clipboard operation
cli copied to clipboard

Add kubectl shp for release

Open liangyuanpeng opened this issue 1 year ago • 16 comments

Changes

  • Change prefix cli to shp for release

  • Add kubectl plugin of shp for release

  • Change replacements to name_template for archive files

Because replacements will be deleted and it's not correctly working for multiple archives.

Ref from goreleaser:
https://goreleaser.com/deprecations/?h=replacements#archivesreplacements

The replacements will be removed soon from the archives section, as it was never handled correctly when multiple archives were being used, and it also causes confusion in other places.

You can still get the same features by abusing the name_template property.

Fixes #179

Related:

  • #102

Tested

gorelease logs:

• writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/shp_linux_arm64/shp
    • building                                       binary=dist/shp_linux_amd64_v1/shp
    • building                                       binary=dist/shp_darwin_amd64_v1/shp
    • building                                       binary=dist/shp_darwin_arm64/shp
    • building                                       binary=dist/shp_windows_amd64_v1/shp.exe
    • building                                       binary=dist/shp_windows_arm64/shp.exe
    • building                                       binary=dist/kubectl-shp_linux_amd64_v1/kubectl-shp
    • building                                       binary=dist/kubectl-shp_linux_arm64/kubectl-shp
    • building                                       binary=dist/kubectl-shp_darwin_amd64_v1/kubectl-shp
    • building                                       binary=dist/kubectl-shp_darwin_arm64/kubectl-shp
    • building                                       binary=dist/kubectl-shp_windows_amd64_v1/kubectl-shp.exe
    • building                                       binary=dist/kubectl-shp_windows_arm64/kubectl-shp.exe
    • took: 11m27s
  • generating changelog
  • archives
    • creating                                       archive=dist/shp_v0.99.0_linux_arm64.tar.gz
    • creating                                       archive=dist/shp_v0.99.0_linux_x86_64.tar.gz
    • creating                                       archive=dist/shp_v0.99.0_macOS_x86_64.tar.gz
    • creating                                       archive=dist/shp_v0.99.0_macOS_arm64.tar.gz
    • creating                                       archive=dist/shp_v0.99.0_windows_arm64.tar.gz
    • creating                                       archive=dist/shp_v0.99.0_windows_x86_64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_windows_arm64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_linux_x86_64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_linux_arm64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_macOS_x86_64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_macOS_arm64.tar.gz
    • creating                                       archive=dist/kubectl-shp_v0.99.0_windows_x86_64.tar.gz
    • took: 39s
  • calculating checksums
  • publishing
    • scm releases
      • creating or updating release                 repo=liangyuanpeng/shipwright-cli tag=v0.99.0
      • release updated                              name=v0.99.0 release-id=99490864 request-id=2[34](https://github.com/liangyuanpeng/shipwright-cli/actions/runs/4696180341/jobs/8326032835#step:5:35)0:450B:2DB4B57:2EEA3BB:6438D0D6
      • uploading to release                         file=dist/shp_v0.99.0_linux_arm64.tar.gz name=shp_v0.99.0_linux_arm64.tar.gz
      • uploading to release                         file=dist/shp_v0.99.0_linux_x86_64.tar.gz name=shp_v0.99.0_linux_x86_64.tar.gz
      • uploading to release                         file=dist/shp_v0.99.0_macOS_arm64.tar.gz name=shp_v0.99.0_macOS_arm64.tar.gz
      • uploading to release                         file=dist/shp_v0.99.0_macOS_x86_64.tar.gz name=shp_v0.99.0_macOS_x86_64.tar.gz
      • uploading to release                         file=dist/shp_v0.99.0_windows_arm64.tar.gz name=shp_v0.99.0_windows_arm64.tar.gz
      • uploading to release                         file=dist/shp_v0.99.0_windows_x86_64.tar.gz name=shp_v0.99.0_windows_x86_64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_windows_arm64.tar.gz name=kubectl-shp_v0.99.0_windows_arm64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_linux_x86_64.tar.gz name=kubectl-shp_v0.99.0_linux_x86_64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_linux_arm64.tar.gz name=kubectl-shp_v0.99.0_linux_arm64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_macOS_x86_64.tar.gz name=kubectl-shp_v0.99.0_macOS_x86_64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_macOS_arm64.tar.gz name=kubectl-shp_v0.99.0_macOS_arm64.tar.gz
      • uploading to release                         file=dist/kubectl-shp_v0.99.0_windows_x86_64.tar.gz name=kubectl-shp_v0.99.0_windows_x86_64.tar.gz
      • uploading to release                         file=dist/checksums.txt name=checksums.txt
      • published                                    url=https://github.com/liangyuanpeng/shipwright-cli/releases/tag/v0.99.0
      • took: 11s

More info at https://github.com/liangyuanpeng/shipwright-cli/actions/runs/4696180341/jobs/8326032835

image

Submitter Checklist

  • [ ] ~~Includes tests if functionality changed/was added~~
  • [ ] Includes docs if changes are user-facing
  • [ ] Set a kind label on this PR
  • [x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

~~Maybe should be add release note after finished for krew?~~

Release kubectl shp binary

liangyuanpeng avatar Apr 14 '23 05:04 liangyuanpeng

From the SHP Grooming session, @liangyuanpeng is this PR ready for review? per the [WIP].

qu1queee avatar Apr 19 '23 13:04 qu1queee

@qu1queee Thanks for your remind , I think it's ready for review.

Will be working for submitting plugins to krew and automating release it ,after kubectl shp released.

liangyuanpeng avatar Apr 20 '23 09:04 liangyuanpeng

/lgtm

Thanks for the contribution, @liangyuanpeng! 🙇‍♀️

/assign @SaschaSchwarze0 /cc @akram

otaviof avatar Apr 21 '23 05:04 otaviof

@otaviof: GitHub didn't allow me to request PR reviews from the following users: akram.

Note that only shipwright-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm

Thanks for the contribution, @liangyuanpeng! 🙇‍♀️

/assign @SaschaSchwarze0 /cc @akram

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 21 '23 05:04 openshift-ci[bot]

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar May 17 '23 09:05 openshift-ci[bot]

/retest

liangyuanpeng avatar May 18 '23 02:05 liangyuanpeng

@liangyuanpeng: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 18 '23 02:05 openshift-ci[bot]

@liangyuanpeng from the Shipwright Refinement meeting, can we help you here?

qu1queee avatar Jul 26 '23 13:07 qu1queee

/retest

qu1queee avatar Oct 04 '23 08:10 qu1queee

/ok-to-test

qu1queee avatar Oct 04 '23 13:10 qu1queee

Tests have no logs anymore and I cannot re-run them from the GitHub Actions UI. Will try another retry here and if this does not work, I am afraid I have to do a close and reopen. /honk

HeavyWombat avatar Oct 04 '23 13:10 HeavyWombat

/retest

HeavyWombat avatar Oct 04 '23 13:10 HeavyWombat

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from otaviof. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 04 '23 13:10 openshift-ci[bot]

@liangyuanpeng Could you have a look into rebasing this PR? The feature branch is behind some 15 commits. Just realized, I think @SaschaSchwarze0 mentioned that he has something in the working that will probably cover the Verify failure. So we need to wait for that fix, too.

HeavyWombat avatar Oct 04 '23 13:10 HeavyWombat

@HeavyWombat checking on the status of this. Should another community member rebase and re-submit this PR?

adambkaplan avatar Jun 13 '24 14:06 adambkaplan

@HeavyWombat checking on the status of this. Should another community member rebase and re-submit this PR?

I'll have a look tomorrow.

HeavyWombat avatar Jun 13 '24 18:06 HeavyWombat