build icon indicating copy to clipboard operation
build copied to clipboard

Minor changes needed to adhere to tekton-provenance format

Open sbose78 opened this issue 4 years ago • 5 comments

Modify name of literals to "automatically" have Tekton Chains push signatures and attestation. See format.

  • Modify shp-output-image to *IMAGE_URL
  • write out IMAGE_URL to a result ( update to step generation )
  • modify result named shp-image-digest to *IMAGE_DIGEST

Here's how the diff looks like: https://www.diffchecker.com/S6oLSCE0

I was successful upon making the above changes manually.

image

sbose78 avatar Oct 13 '21 16:10 sbose78

/kind feature

adambkaplan avatar Oct 13 '21 16:10 adambkaplan

Tekton Chains looks for results, shp-output-image is a param.

SaschaSchwarze0 avatar Oct 13 '21 19:10 SaschaSchwarze0

Correct, needs changes to the build strategy to write that out to a result. Got it working locally 🕹️

sbose78 avatar Oct 14 '21 14:10 sbose78

Right, maybe we introduce a tekton-chains-enabled toggle in the controller config and if it is one it will take care of it (by adding a post-step to write the two results if possible).

SaschaSchwarze0 avatar Oct 14 '21 16:10 SaschaSchwarze0

Marking this as needing a SHIP, since this will impact how build strategy implementations.

adambkaplan avatar Nov 17 '21 14:11 adambkaplan