build icon indicating copy to clipboard operation
build copied to clipboard

BuildRun reconciliation sets status on parent Build object

Open adambkaplan opened this issue 4 years ago • 1 comments

If a BuildRun's parent Build object has the BuildRun deletion annotation, the reconciliation of a BuildRun can cause the parent Build object to have the status SetOwnerReferenceFailed. This pollutes the status of the Build object, since its top-level status includes information set by individual child objects.

If the BuildRun reconciler can't set the owner reference on a BuildRun object, this error should be reported in the status of the BuildRun object.

See https://github.com/shipwright-io/build/pull/824/files#r659178157

/kind bug

adambkaplan avatar Jun 28 '21 19:06 adambkaplan

Discussion in the grooming:

  • Eventually, build's .status will probably go away since we'll be moving the validation to a webhook.
  • Therefore, it makes more sense to move the SetOwnerReferenceFailed to BuildRun's status.

sbose78 avatar Jul 14 '21 13:07 sbose78