shipwright-io
SHIP-0039: Allow node selector on `Build` and `BuildRun` to be set
Feature
Add option to set nodeSelector on Build and BuildRun objects.
Part of implementation for SHIP-0039
I would like to take this up and would love for any advice or resource to help with this issue.
@aryan-py happy to fill in the details here!
- Step "0" is to familiarize yourself with the Contributing Guide for writing pull requests. This will help a lot once it comes time to review your contribution.
- Next, follow the Development guide to get your local environment set up to build and test the Build project.
- To get started on the code, I also recommend you read the SHIP-0039 proposal to get the "big picture" of what the community wants to build. This issue covers one part (the
node-selectorfield). - Once you think you're ready to get coding, I believe we'll want changes to be made in the following locations:
--
pkg/apis/build/v1beta1: add theNodeSelectorfield to the Build and BuildRun spec objects. --pkg/reconciler/buildrun/resources: Merge the node selectors for theBuildandBuildRunobject into a single map, and add them to the Tekton TaskRun generated here. Node selectors can be set on TaskRuns using the Pod Template field - they provide an example of how to do this with YAML here.
You may also want to walk through some of the Tekton tutorials to understand how the builds are ultimately run.
hey @adambkaplan I would be very happy to help you in this, It will help me understand more about shipwright and also help me learn more :) . @aryan-py if you're not planning to work or have been busy with any other task I would like to take this up. Thanks!
@aryan-py @7h3-3mp7y-m4n @giepa so far we have not received any pull requests for this feature. They are more than welcome.
Please don't wait for an explicit assignment on GitHub - go ahead and start contributing!
Okay @adambkaplan . If I run into some problem I'll share it with you on slack, okay?