shiptest-ss13
Fix some reagent explosions not exploding hard enough
About The Pull Request
There is a quick in chemcode more specificly in /datum/chemical_reaction/proc/on_reaction(datum/reagents/holder, created_volume). The quirk being that created_volume is actually the number of times the reaction occur.
This means that the strength of an explosion will be divided by the volume of required
This PR fixes this by making using by using either the volume of created explosive or the volume of the required reagent for the explosion.
Example : lets say you want to detonate RDX with telsium to get a strengthdiv of 3 instead of the 6 that you get by just heating the RDX. This reaction require 2u of reagent which right now mean the power of the explosion is divided by 2, which leaves you with a stregthdiv of 6.
Here are the reactions that were changed by this PR :
| new_strengthdiv | old_strengthdiv | theorical_strengthdiv | type |
|---|---|---|---|
| 3 | 6 | 2 | /datum/chemical_reaction/reagent_explosion/nitroglycerin |
| 12 | 24 | 6 | /datum/chemical_reaction/reagent_explosion/rdx |
| 3 | 6 | 3 | /datum/chemical_reaction/reagent_explosion/rdx_explosion2 |
| 3 | 6 | 3 | /datum/chemical_reaction/reagent_explosion/rdx_explosion3 |
| 5 | 10 | 5 | /datum/chemical_reaction/reagent_explosion/penthrite_explosion_epinephrine |
| 5 | 10 | 5 | /datum/chemical_reaction/reagent_explosion/penthrite_explosion_atropine |
| 10 | 20 | 10 | /datum/chemical_reaction/reagent_explosion/potassium_explosion |
| 10 | 20 | 10 | /datum/chemical_reaction/reagent_explosion/potassium_explosion/holyboom |
| 6 | 24 | 6 | /datum/chemical_reaction/reagent_explosion/methsplosion/methboom2 |
| 100 | 200 | 100 | /datum/chemical_reaction/reagent_explosion/teslium_lightning |
theorical_strengthdiv: the strengthdiv as written in code. old_strengthdiv: effective stregthdiv of the reaction before the PR new_strengthdiv: effective strengthdiv of the reaction after the PR
Why It's Good For The Game
On mix explosions not being underpowered is good.
Changelog
:cl: balance: Fix on mix reagent explosions being underpowered. /:cl:
