Shiptest icon indicating copy to clipboard operation
Shiptest copied to clipboard

Glass Floor Transparency Fix

Open FslashN opened this issue 7 months ago • 2 comments

About The Pull Request

Port of: https://github.com/PentestSS13/Pentest/pull/288

Addresses: https://github.com/PentestSS13/Pentest/issues/127

Fixes and improves glass floors and material floors made from glass (and possibly other stuff). Includes some refactoring of the transparency element and some other code changes to make everything else possible. This should also fix the 'ghost turfs' that sometimes sprang up on underlay turfs, but I can't really confirm it for sure without more testing.

copyTurf() is problematic and should be addressed in the future. For more information on why stuff wasn't working right, check my writeup in the linked issue. This method uses relevant baseturfs instead of the old ZTRAIT_BASETURF lookup, and I think it looks a lot better. The drawback is that transparent underlays cannot tile together.

Why It's Good For The Game

https://github.com/user-attachments/assets/419298b9-4477-4199-b619-fb009a530425

Changelog

:cl: fix: Fixed glass floor underlaying incorrectly and some other 'ghost turf' issues. refactor: Refactored and improved turf transparency. /:cl:

FslashN avatar Apr 29 '25 20:04 FslashN

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 08 '25 20:05 github-actions[bot]

It's failing the build stage, and I am not sure why. Seems like it's also happening in https://github.com/shiptest-ss13/Shiptest/pull/4807 too. Might need to refresh the checks later.

FslashN avatar May 10 '25 00:05 FslashN

I do not want to merge untested potentially broken multi-z code into the codebase.

thgvr avatar Jun 14 '25 21:06 thgvr