shiptest-ss13
Chain of Command - IRMG Rank Pins
About The Pull Request
Implements uniform-attachable rank pins for every member (in-game and not implemented) of the IRMG! At a glance, you can now easily tell who is technically above or below you in the Group (as if that matters)!
What job/rank corresponds to each pin (Class 1 is applied to Inteq ERT at the moment):
Without the clutter:
And, and mspaint mockup of the direct rank structure (using modern NATO paygrades as a reference point) that was formed in loredev the other day:
Yes, I do plan on doing this for the other military factions. PGF is probably next.
Why It's Good For The Game
Flavour! Flavour is awesome. Sovl
Also, Inteq not having any gold on their turtlenecks is a travesty. This fixes that!
Changelog
:cl: add: Rank patches for Inteq! You'll find them pinned to your uniform when you wake up from cryo. /:cl:
oh yeah i forgot to do different worn sprites for kepori because i have no idea where i would start doing that
can't believe we got this for inteq before pgf
i ran it through my mind the other day - pgf already sort of has the cloaks and those are a little more swag than just pins
The icons for this do not really work, they have floating pieces and look more just like the symbol rather than a pin you would wear. Also, what's up with the duplicated mob states?
The icons for this do not really work, they have floating pieces and look more just like the symbol rather than a pin you would wear.
Any actual suggestions? I'm not really, like, a world-class spriter.
Also, what's up with the duplicated mob states?
Accessories are handled strangely. I'm potentially too stupid to figure out an actually clean way to have them render as intended. You can see the other methods I attempted in commits 8b3444a through 44b44d9.
Actually I remember why, accessories are handled differently than pretty much all other rendering code and thus don't have the same features. It's awful and I hate it.
For the sprite, I'd imagine something more like a patch that's affixable to clothing, where the gold bits (that you've already made) would be more of an embossment. Another issue arises in any curved or diagonal sections you've made - they use a gradient of colors (3 shades in a row in this case) where having it be continuous color for most of it would make the shape much better.
I'd also really recommend looking into world icon for this - they're huge and I don't think it would be difficult to make a smaller sized version.
Yeah, alright - I'll give that a shot when I get a minute.
she did not get a minute
If you'd like help with the assets, feel free to ask one of our artists/me on discord
If at any point you want to continue work on this, you can:
- Make a new PR
- Ask a maintainer to reopen this
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
closing because there is some sort of curse placed on this pr and i do not have the power to counter it